More comprehensive error messages for checkout validation #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
changed the title
lchrusciel
approved these changes
Jan 23, 2020
|
|
||
| /** @var CartReadyForCheckout $constraint */ | ||
| $validationMessage = $constraint->message; | ||
| switch ($cart->getState()) { |
There was a problem hiding this comment.
Wouldn't it be more granular if we would just create 4 different validators?
There was a problem hiding this comment.
Yes, but then you'd have to have control over in which order they are validated. It doesn't make sense to return a response like payment method not chosen if the cart hasn't been addressed yet. What we could do however is make multiple constraints that are validated by the same validator. Because the logic of the validator is always the same. I am not so sure however if that is a good idea.
lchrusciel
approved these changes
Jan 27, 2020
|
Thanks, @mamazu! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #574