-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test app API #321
Fix test app API #321
Conversation
sylius.security.api_regex: "^/api" | ||
sylius.security.shop_regex: "^/(?!%sylius_admin.path_name%|new-api|api/.*|api$|media/.*)[^/]++" | ||
sylius.security.new_api_route: "/new-api" | ||
sylius.security.shop_regex: "^/(?!%sylius_admin.path_name%|api/.*|api$|media/.*)[^/]++" | ||
sylius.security.new_api_route: "/api/v2" | ||
sylius.security.new_api_regex: "^%sylius.security.new_api_route%" | ||
sylius.security.new_api_admin_route: "%sylius.security.new_api_route%/admin" | ||
sylius.security.new_api_admin_regex: "^%sylius.security.new_api_admin_route%" | ||
sylius.security.new_api_shop_route: "%sylius.security.new_api_route%/shop" | ||
sylius.security.new_api_shop_regex: "^%sylius.security.new_api_shop_route%" | ||
sylius.security.new_api_user_account_route: "%sylius.security.new_api_shop_route%/account" | ||
sylius.security.new_api_user_account_regex: "^%sylius.security.new_api_user_account_route%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no further need to define these parameters as there was extracted to bundles in Sylius in 1.9 version I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simply copied it from Sylius-Standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check if they're necessary and remove if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right @GSadee, all those parameters are already defined in bundles, so I removed them from the test app.
Co-authored-by: Grzegorz Sadowski <sadowskigp@gmail.com>
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
Thanks, Victor! 🎉 |
Fix and enable the API in test app.