Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not enforcing someday limit when user clicks migrate arrow #148

Open
1 task done
tyler-dane opened this issue Oct 7, 2024 · 0 comments
Open
1 task done

Not enforcing someday limit when user clicks migrate arrow #148

tyler-dane opened this issue Oct 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tyler-dane
Copy link
Contributor

tyler-dane commented Oct 7, 2024

Prerequisites

  • Using an up-to-date main branch

Expected Behavior

  1. User is viewing a week with less than 9 someday events
  2. User migrates a someday event forward
  3. The next week already has 9 someday events
  4. The warning alert is shown and the event is not migrated

Current Behavior

1-3: same
4. The event is migrated
5. When going to the next week, all 10 events are rendered

error
no error

Possible Solution (Not obligatory)

During regular migrations, we use the isAtMonthlyLimit and isAtWeeklyLimit selectors before allowing a migration. Consider creating a new selector called something like canMigrate or isMigrateForwardAllwed, which accepts an argument of "forward" or "backward." It then uses the current viewStart and viewEnd (from redux) and determines whether the operation is acceptable by seeing if the user has less than the limit on the next/previous view.

Context

This bug results in bad UX for users. If they have lots of someday events in the same week, they won't all render properly

@tyler-dane tyler-dane added the bug Something isn't working label Oct 7, 2024
@tyler-dane tyler-dane removed this from v1 Cleanup Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

1 participant