Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorizers to be moved from graph-commons #1401

Open
4 tasks
jachro opened this issue Mar 22, 2023 · 0 comments
Open
4 tasks

Authorizers to be moved from graph-commons #1401

jachro opened this issue Mar 22, 2023 · 0 comments

Comments

@jachro
Copy link
Contributor

jachro commented Mar 22, 2023

As a renku-graph developer, I'd like Authorizers and Authenticators to be moved from the graph-commons module

The problem:
Because the mentioned tooling sits in the graph-commons module, the Datasets graph cannot be used to fetch data needed by the Authorizers. The reason is that graph-commons does not (and should not) depend on the entities-search module so tests for the Authorizers couldn't be written in a sane way.

Acceptance criteria:

  • move both Authenticators and Authorizers into a new graph-auth module
  • try to find out which of the queries currently back up the auth tooling should/can be using data from the Datasets graph
    • if it would be good to use the Datasets graph, make the new module depending on the entities-search module
    • modify the relevant queries
@jachro jachro converted this from a draft issue Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

No branches or pull requests

1 participant