Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper: VISA description #3

Closed
MatthieuDartiailh opened this issue Sep 29, 2022 · 2 comments
Closed

JOSS paper: VISA description #3

MatthieuDartiailh opened this issue Sep 29, 2022 · 2 comments

Comments

@MatthieuDartiailh
Copy link

I am bothered by the strong link made between VISA and SCPI. VISA provides an abstraction over the physical bus used for communication but does not mandate the format of the message circulating on that bus (except for IEEE 488.2 messages). In particular VISA also provide access to register based instruments for which SCPI makes no sense at all.

I am not sure how this should be phrased to be palatable for the reader but I believe that such a strong implicit coupling should be avoided as it tends to create some confusions.

openjournals/joss-reviews#4752

@OHildreth
Copy link
Contributor

OHildreth commented Nov 3, 2022

Authors’ Response to Reviewer Comment
Thank you, you are correct. We have removed references to SCPI from the document.

Original Text
The Virtual Instrument Software Architecture (VISA)[@NI-VISA_download, @wiki_VISA] is a simple Application Programming Interface (API) implementing the Standard Commands for Programmable Instruments (SCPI)[@scpi] to control test and measurement instrumentation from a computer.

Updated Text
The Virtual Instrument Software Architecture (VISA)[@NI-VISA_download, @wiki_VISA] is a simple Application Programming Interface (API) to control test and measurement instrumentation from a computer.

@MatthieuDartiailh
Copy link
Author

The edit looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants