Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] FolderDaemon doesn't work when blacklist pattern array is empty #6

Closed
Sv443 opened this issue Jan 12, 2021 · 1 comment · Fixed by #9
Closed

[Bug] FolderDaemon doesn't work when blacklist pattern array is empty #6

Sv443 opened this issue Jan 12, 2021 · 1 comment · Fixed by #9
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Sv443
Copy link
Member

Sv443 commented Jan 12, 2021

  • .forEach loop isn't entered since this._blacklistPattern is an empty array.
  • Additionally, the same file hash is probably added onto the promises array multiple times. A return after line 164 would probably fix this.

image

At src/classes/FolderDaemon.js:157

@Sv443 Sv443 added the bug Something isn't working label Jan 12, 2021
@Sv443 Sv443 self-assigned this Jan 12, 2021
@Sv443 Sv443 added this to the 1.11.2 milestone Jan 12, 2021
@Sv443
Copy link
Member Author

Sv443 commented Jan 12, 2021

Temporary fix: set blacklist pattern to something that is a valid glob pattern but doesn't match any of the files, example: [ "**/path/that_doesnt/exist/*" ]

@Sv443 Sv443 mentioned this issue Jan 13, 2021
4 tasks
Sv443 added a commit that referenced this issue Jan 21, 2021
@Sv443 Sv443 linked a pull request Jan 21, 2021 that will close this issue
8 tasks
@Sv443 Sv443 closed this as completed in #9 Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant