Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCL should make use of peer dependencies #29

Closed
Sv443 opened this issue Aug 3, 2021 · 0 comments
Closed

SCL should make use of peer dependencies #29

Sv443 opened this issue Aug 3, 2021 · 0 comments
Assignees
@Sv443
Labels
enhancement New feature or request
Milestone
1.14.2

Comments

@Sv443
Copy link
Member

Sv443 commented Aug 3, 2021

Currently mysql is declared as a dependency, meaning it must be installed (even if it is not needed), adding quite a lot of sub-dependency clutter.
Solution is to declare it as a peer dependency and doing some Node magic to throw an error if a peer function is used without its dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sv443 Sv443

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.14.2
Development

No branches or pull requests
1 participant
@Sv443