Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homeCoordinates #4

Open
magma1447 opened this issue Jan 30, 2024 · 2 comments
Open

homeCoordinates #4

magma1447 opened this issue Jan 30, 2024 · 2 comments

Comments

@magma1447
Copy link

This is mostly an FYI.

It seems like the Geocaching side of oAuth has stopped returning homeCoordinates as a part of the data structure. By looking at your code I assume your tests will fail due to this.

I will try to ask them if it's intentional. The data can still be retrieved with the API method /v{api-version}/users/{referenceCode}. But in my case it means an extra http call upon every oauth. On the other hand I guess most API partners don't use the home coordinates for anything.

@Surfoo
Copy link
Owner

Surfoo commented Jan 31, 2024

Hello,

I tried in production with https://geocaching.vaguelibre.net/api/ and it works, same thing in staging on my computer. Maybe it was just temporary..

@magma1447
Copy link
Author

I think the default fields that are returned by the API have changed. To my knowledge (and from what I can find in git) Project-GC hasn't used $provider->setResourceOwnerFields before. But now when I added that and included homeCoordinates I am seeing them again.

I am currently waiting on more confirmations that my current code works for all the users. I have had some that have had issues logging in. This while I haven't seen any issues myself yet. I have logged out and in again a lot, and also removed some related data in the DB for my user. But I have had a bit too much success. Hard to test and debug without reproduction cases. :/

PS! Note that I am using v1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants