Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Review #56

Open
rahulkore opened this issue Jun 17, 2023 · 0 comments
Open

Project Review #56

rahulkore opened this issue Jun 17, 2023 · 0 comments

Comments

@rahulkore
Copy link

  • Functionality Wise

    • Some links are broken on the website, you should not include such links/pages if it is not working.
    • wireframing looks good.
    • No client side data validation.
    • On a meta level , Always remeber if certain feature you haven't implemented properly then just remove it. A Website with few working features is more
      interesting and functional than a website with n different things out of which only few works.
  • Coding

    • No client side data validation
    • Client side data validation is very important.
    • looks good , looks attractive , good job on that part .
    • The wireframe looks great overall.
    • The navigation is smooth on the site.
    • Redux arch is used properly , kudos on that .
    • Hooks understanding is also on point .
    • Standard Coding practices are used .
    • Not much comments in code / Always include comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant