-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tinyglobby
inconsistent to fast-glob
with absolute patterns that have \
#72
Comments
i'm on windows and absolute patterns should work, can you provide a minimal repro? whatever it is if it's perf related #69 will probably solve it |
clone VP (VitePress) repo then |
it's using an absolute path with |
FYI: I added // foo.js => node ./foo.js
import { resolve, normalize } from 'node:path'
import { fileURLToPath } from 'node:url'
import { globSync } from 'tinyglobby'
const ROOT = fileURLToPath(import.meta.url)
const r = (p) => normalize(resolve(ROOT, '..', p))
console.log(r('src/node/worker_*.ts'))
console.log(
globSync('src/node/worker_*.ts', {
cwd: r('.'),
onlyFiles: true,
expandDirectories: false
})
)
console.log('RUNNING') |
tinyglobby
hangs when using absolute paths in patterns on Windowstinyglobby
inconsistent to fast-glob
with absolute patterns that have \
https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#how-to-write-patterns-on-windows fast-glob handles that, but doesn't recommend Using simple replacement works: |
will try to make it as consistent to fast-glob as possible |
Any news on this? This is probably the biggest reason that prevents many tools from switch from fast-glob to tinyglobby. |
is it? thought it wasn't a priority since the issue author's linked repo no longer has the problem. can take a deeper look into it for the next release that i want to release ASAP |
From what I've gathered: The windows glob issues are very important. OP came from vitepress having this issue and remix and analog also referring to this issue. I wanted to make a PR in npm-check-updates and came across the same issue as a dozen tests started to fail after switching from fast-glob to tinyglobby. |
Check vuejs/vitepress#4357
The text was updated successfully, but these errors were encountered: