From 67102f1dee92bd08ee3282b6684798e185d1dd75 Mon Sep 17 00:00:00 2001 From: Jason <84899178+kommunarr@users.noreply.github.com> Date: Tue, 14 Jan 2025 22:34:45 +0000 Subject: [PATCH] Add autoplay toggle to the video player (#5866) * Add autoplay toggle to the video player * Fix (pre-existing) bug where mobile Shaka overflow menu overflows into top nav bar * Update confusing autoplay labels to use consistent language * Update src/renderer/components/ft-shaka-video-player/player-components/AutoplayToggle.js Co-authored-by: absidue <48293849+absidue@users.noreply.github.com> * Have autoplay toggle value update when setting updates elsewhere, e.g., in another window * Apply suggestions from code review Co-authored-by: absidue <48293849+absidue@users.noreply.github.com> * Remove now-redundant playlist pause feature * Update overflow width threshold --------- Co-authored-by: absidue <48293849+absidue@users.noreply.github.com> --- .../WatchVideoRecommendations.css | 6 -- .../WatchVideoRecommendations.vue | 28 ------- .../ft-shaka-video-player.css | 2 + .../ft-shaka-video-player.js | 50 +++++++++++- .../player-components/AutoplayToggle.js | 79 +++++++++++++++++++ .../player-settings/player-settings.vue | 14 ++-- .../watch-video-playlist.js | 11 --- .../watch-video-playlist.vue | 12 --- src/renderer/main.js | 2 - src/renderer/views/Watch/Watch.js | 73 +++++++++-------- src/renderer/views/Watch/Watch.vue | 4 +- static/locales/en-GB.yaml | 4 - static/locales/en-US.yaml | 10 +-- 13 files changed, 186 insertions(+), 109 deletions(-) create mode 100644 src/renderer/components/ft-shaka-video-player/player-components/AutoplayToggle.js diff --git a/src/renderer/components/WatchVideoRecommendations/WatchVideoRecommendations.css b/src/renderer/components/WatchVideoRecommendations/WatchVideoRecommendations.css index cc99e998ff906..b00a7feb4000b 100644 --- a/src/renderer/components/WatchVideoRecommendations/WatchVideoRecommendations.css +++ b/src/renderer/components/WatchVideoRecommendations/WatchVideoRecommendations.css @@ -7,12 +7,6 @@ grid-gap: 8px; } -.autoPlayToggle { - display: flex; - justify-content: flex-end; - align-items: center; -} - .VideoRecommendationsTopBar { display: flex; justify-content: space-between; diff --git a/src/renderer/components/WatchVideoRecommendations/WatchVideoRecommendations.vue b/src/renderer/components/WatchVideoRecommendations/WatchVideoRecommendations.vue index 44e5ffe3c4e1f..754da4ae75a0b 100644 --- a/src/renderer/components/WatchVideoRecommendations/WatchVideoRecommendations.vue +++ b/src/renderer/components/WatchVideoRecommendations/WatchVideoRecommendations.vue @@ -6,14 +6,6 @@

{{ $t("Up Next") }}

-