-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pvlib dependency to v0.8.0 #114
Comments
Hi @anomam -- just curious, when working towards using pvlib 0.8.0 (or future versions), how much do you care about continuing to support the older pvlib versions? For example would it be acceptable to bump the requirement to |
Hi @kanderso-nrel , thanks a lot for your follow-up question. |
Got it, thanks for the info. I think requiring recent pvlib versions for maintenance convenience is reasonable for two reasons: pvlib is still "pre-1.0", and if nobody complains about older versions not being supported then it's no issue anyway! Maybe once pvlib's API hits a stable release it would make sense to follow the NEP-29 convention of all minor releases from the last two years, but that's probably a ways off still. If you're amenable to it, I might open a PR adding support for pvlib 0.8.x, although because I'm not really familiar with the pvfactors codebase I can't promise it'll be ready any time soon, so don't let it dissuade you or someone else from getting to it first :) |
Thank you @kanderso-nrel, I really appreciate your inputs. It's the first time I hear about the NEP-29 convention, that's interesting stuff! I'll take a look at your PR today |
pvlib-python v0.8.0 has breaking API changes that will require a code update in pvfactors.
The text was updated successfully, but these errors were encountered: