Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https://sonichu.com/cwcki/ #144

Open
Dregench opened this issue Sep 13, 2020 · 5 comments
Open

Add https://sonichu.com/cwcki/ #144

Dregench opened this issue Sep 13, 2020 · 5 comments

Comments

@Dregench
Copy link

Based on the precedent set by #76 I was wondering if the CWCki would be possible.

@the-j0k3r
Copy link
Member

Sure, but not anything to be done soon, unless theres a PR, its a busy time for me.

@chrisburnor
Copy link

I was looking to add dwarffortresswiki.org as well. I wonder if there's a pattern or template we could put on the README for how to add additional wiki media based wikis to this? I imagine that each would need a bit of extra styling just for it, but it shouldn't be too hard for the community to put those together if we have a modular pattern to follow.

@the-j0k3r
Copy link
Member

the-j0k3r commented Oct 5, 2020

I wonder if there's a pattern or template we could put on the README for how to add additional wiki media based wikis to this?

There is none, and writing this up isn't something I have time for atm or for a long time, however, as a rule of thumb the way to go is if you study the style and notice how specific sites have their own @-moz-document areas for more domain specific fixes. We would also in addition need to add the domain(s) to be added to two main sections (because these will likely have common css.

So

  1. add the domain to be added to this area

and this area

@-moz-document

  • If when you add the above your domain isnt styled, make sure you have the vector theme enabled. We dont support others.
  • if you have vector theme only and nothing hapened check what theme the domain uses. We dont support anything but vector.
  • if none of the above, ask us, but its likely some sites wont share much common css with other wikis or some other issue.
  1. if the domain added shows issues in styling, then you create a @-moz-document for the domain and add doamin specific fixes to this area.

The rest how to contribute in on README or CONTRIBUTING.md files

And the main key is look how the style is built, use the browser inspector to see whats going on and you cant go tooo far off the mark.

Notice how inline styles are overridden and how they differ from regular css classes/rules and match the same idea.

Good luck. =)

@the-j0k3r
Copy link
Member

Please read #151

@the-j0k3r
Copy link
Member

This isnt as trivial as adding regexp("https?:\/\/sonichu\.com/cwcki\/.*$") to both first two @-moz-document areas, so Im not getting involved because of the time required to properly fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants