Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StructuredConstraintRef struct seems unnecessary #71

Closed
jmaack24 opened this issue Feb 27, 2019 · 5 comments
Closed

StructuredConstraintRef struct seems unnecessary #71

jmaack24 opened this issue Feb 27, 2019 · 5 comments
Labels
Stale

Comments

@jmaack24
Copy link

The JuMP.ConstraintRef struct allows takes the model type as a parameterized type provided it is a subtype of JuMP.AbstractModel. Since this is true of StructuredModel, it seems unnecessary to create a StructJuMP specialized version of this struct.

More importantly, because there is no abstract super type for JuMP.ConstraintRef, StructJuMP's usage of its own specialized constraint reference struct means that code cannot easily work with a JuMP.Model or a StructJuMP.StructuredModel easily.
@blegat
Copy link
Collaborator

blegat commented Feb 27, 2019

That makes sense, it can be replaced by ConstraintRef{StructuredModel, Int, <:AbstractShape}.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Jun 19, 2020
@blegat blegat removed the Stale label Jun 19, 2020
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Jul 20, 2020
@blegat blegat reopened this Jul 26, 2020
@blegat blegat removed the Stale label Jul 26, 2020
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Aug 26, 2020
@github-actions github-actions bot closed this as completed Sep 1, 2020
@kibaekkim kibaekkim reopened this Sep 1, 2020
@kibaekkim kibaekkim removed the Stale label Sep 1, 2020
@github-actions
Copy link

github-actions bot commented Oct 2, 2020

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Oct 2, 2020
@github-actions github-actions bot closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blegat @kibaekkim @jmaack24