no save for project settings

[shaunc]

Similar to #351 -- on the project config general settings there should be a save button.

[knownasilya]

Don't those pages save automatically once you make a change?

If not, then I'm not sure which page you're talking about exactly (could you post a screenshot).

[shaunc]

Many of the controls trigger automatic update, but pasting into the textboxes for SSH keys in the general settings (not those specifically for git) triggers no save. (Blur doesn't seem to trigger save either. Perhaps if I were to actually type, but pasting seems normal thing to do for SSH keys.)

[knownasilya]

Ah, so that's the issue. We might as well be consistent in how we save, so a save button everywhere makes sense, although we need to make it an easily reusable component so we're not duplicating code.

[shaunc]

Sounds good too me. :) Indeed to avoid duplication you might want to make those parallel ssh textboxes a component as well.

[shaunc]

hmm... well on the other hand, if you do have autosave in some places, then maybe the "save" button should (everywhere) only appear if there is a modification to a more complex item like a textbox. To have autosave and a save button seems confusing. I recall there are some issues detecting changes of textboxes (dealing with paste, etc), but I seem to remember it is possible to work around.

[knownasilya]

Seems like there are a few pages that have auto-save, and all of them aren't plugin pages, but core pages. Seems like we should standardize how we save, either button or auto, not and/or. So we choose what we want to use consistently across the project.

I suggest just using the button everywhere.

[knownasilya]

Branch settings page now has a button see 2e0c659

[knownasilya]

Closing this. Will open a general issue to convert all autosaves to a save button.