Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RecordsKeeper.Transfer to user MsgTransferResponse sequence number #353

Closed
asalzmann opened this issue Nov 17, 2022 · 0 comments · Fixed by #376
Closed

Update RecordsKeeper.Transfer to user MsgTransferResponse sequence number #353

asalzmann opened this issue Nov 17, 2022 · 0 comments · Fixed by #376

Comments

@asalzmann
Copy link
Contributor

The RecordsKeeper.Transfer method fetches the sequence number like so k.IBCKeeper.ChannelKeeper.GetNextSequenceSend, to store a transfer callback. However, this is no longer needed as of IBC v3.4.0, which returns a sequence number from k.TransferKeeper.Transfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Stride Chain Development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update RecordsKeeper.Transfer to use msgTransferResponse sequence number notional-labs/stride
1 participant
@asalzmann