Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ solvers display incorrect results when real-valued initial populations are used on the model. #573

Closed
jtcooper10 opened this issue Jun 30, 2021 · 0 comments · Fixed by #557
Assignees
Labels
bug Something isn't working ✔️​ Issue / PR has been resolved
Milestone

Comments

@jtcooper10
Copy link
Collaborator

As an example, the LotkaVolterra Oscillator exclusively uses initial values on the range [0, 1), which results in an output of uniform 0s. This can be replicated with the ODECSolver, while the NumPy-based ODESolver displays expected results.

This is likely due to the fact that initial populations are always initialized as unsigned int even for deterministic simulations. We will likely need to provide alternative data structures to support real-valued initial populations.

@jtcooper10 jtcooper10 self-assigned this Jun 30, 2021
@jtcooper10 jtcooper10 added the bug Something isn't working label Jun 30, 2021
@jtcooper10 jtcooper10 linked a pull request Jul 8, 2021 that will close this issue
@ethangreen-dev ethangreen-dev added the ✔️​ Issue / PR has been resolved label Jul 13, 2021
@ethangreen-dev ethangreen-dev added this to the 1.6.3 milestone Jul 13, 2021
@briandrawert briandrawert modified the milestones: 1.6.3, 1.6.4 Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ✔️​ Issue / PR has been resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants