Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vogen generates invalid namespace in SystemTextJsonConverterFactory_g.cs #717

Closed
Healios opened this issue Dec 1, 2024 · 3 comments · Fixed by #718
Closed

Vogen generates invalid namespace in SystemTextJsonConverterFactory_g.cs #717

Healios opened this issue Dec 1, 2024 · 3 comments · Fixed by #718
Labels
bug Something isn't working

Comments

@Healios
Copy link

Healios commented Dec 1, 2024

Describe the bug

It seems that when a namespace contains a hyphen ( - ), an invalid namespace is generated in the file SystemTextJsonConverterFactory_g.cs. The namespace "CRM_API" ends up being "CRM - API".

The namespace is however correct in the value-object's generated partial struct.

Steps to reproduce

  1. Download the following project https://github.com/Healios/vogen-namespace-error
  2. Build it

Expected behaviour

I was expecting the namespace to be "CRM_API".

@Healios Healios added the bug Something isn't working label Dec 1, 2024
@SteveDunn
Copy link
Owner

Thanks for bug report @Healios, and thanks for the repro! It's actually taking the assembly name, which can have a hyphen, and using that without escaping it.
Doing a fix now.

@Healios
Copy link
Author

Healios commented Dec 1, 2024

Ah, got it 👍 Thank you so much for the prompt response @SteveDunn - really appreciate it!

@SteveDunn
Copy link
Owner

This is now in 6.0.0-beta.1. I've upped the major version as it includes a breaking change (albeit as small one), as a result of this fix.

The release notes are here: #719

Thanks again for the feedback. Would welcome your thoughts in the discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants