Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much height at bottom after rendered #87

Open
namgivu opened this issue Aug 26, 2016 · 1 comment
Open

Too much height at bottom after rendered #87

namgivu opened this issue Aug 26, 2016 · 1 comment

Comments

@namgivu
Copy link

namgivu commented Aug 26, 2016

Your code is awesome and very helpful to me. I love it and thank you so much!

Though I would have one small issue - the height of each output page get too much height at the bottom after rendered by calling .dragend().

I guest the height of page container is the total height of all pages inside it and .dragend() not resize its height.

Is this a bug or I'm doing something wrong?

p.s.

Snapshot before calling .dragend()
image

After rendered
image

@namgivu namgivu changed the title Too much high at bottom after rendered Too much height at bottom after rendered Aug 26, 2016
@dominicgan
Copy link

I have the same issue as you, and I've got a hacky fix for this.

Setting the value of height in _setPageDimentions (line 522) to a null string results in no css height value being assigned to the parent container, which means the parent container will take the height of the tallest panel.

The only problem you might have with this is if whitespace at the bottom of panels that are much shorter than the rest. See my codepen for an exaggerated example:

https://codepen.io/dominicgan/full/KgVgBV/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants