Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support Binary & For String and Int #150

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

jogibear9988
Copy link
Contributor

No description provided.

@jogibear9988
Copy link
Contributor Author

I need this in a Web frontend, wich does not know the type of the compared field

@codecov
Copy link

codecov bot commented Mar 28, 2018

Codecov Report

Merging #150 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   82.34%   82.58%   +0.23%     
==========================================
  Files          36       36              
  Lines        3512     3520       +8     
  Branches      487      489       +2     
==========================================
+ Hits         2892     2907      +15     
  Misses        481      481              
+ Partials      139      132       -7
Impacted Files Coverage Δ
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 77.58% <100%> (+0.32%) ⬆️
src/System.Linq.Dynamic.Core/Parser/TypeHelper.cs 88.2% <0%> (+0.47%) ⬆️
...c/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs 98.03% <0%> (+1.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c0d19...a5140a2. Read the comment docs.

@jogibear9988
Copy link
Contributor Author

@StefH : can you merge this and create a nuget?

@StefH
Copy link
Collaborator

StefH commented Mar 29, 2018

I will do this.

@StefH StefH merged commit 7302169 into zzzprojects:master Mar 30, 2018
@StefH StefH changed the title Support Binary & For String and Int Feature: Support Binary & For String and Int Mar 30, 2018
@StefH StefH added the feature label Mar 30, 2018
@StefH
Copy link
Collaborator

StefH commented Mar 30, 2018

Done, see new nuget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants