Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Fix frontend with Kubeflow 1.3 #68

Closed
20 of 23 tasks
wg102 opened this issue Feb 17, 2022 · 3 comments
Closed
20 of 23 tasks

[Epic] Fix frontend with Kubeflow 1.3 #68

wg102 opened this issue Feb 17, 2022 · 3 comments
Labels
kind/epic Tracks related issues; has no size

Comments

@wg102
Copy link
Contributor

wg102 commented Feb 17, 2022

After a few decisions, it was decided that CWA was postponed for now, in favor of speed, jupyter-apis will be upgrade with 1.3 kubeflow frontend. See StatCan/aaw#868 and StatCan/aaw#831 for details.

As of now, the backend was done. [here] (863a996)
What is left is to add our own customization to the front end.

The following is the list of commits relating to the following customizations, and list them under the related feature, originaly here. An issue will be created for each checkbox.

Front end customizations:

Back end customizations:

  • support for start/stop notebooks
  • if we want, adjust our backend to support their new volumes page : We do not because of Pro-B
  • check for any new endpoints in 1.3 api that are not currently implemented in ours
    • jupyter (Skye)
    • common (Jose)
    • volumes

TO TEST

  • Deleting anotebook ONLY deletes a notebook.
  • Logos for the table

TO DO:

  • New validation (including but not only) Limit CPU, limit Memory.
  • Fix up the i18n once all is merged
@wg102 wg102 added the kind/epic Tracks related issues; has no size label Feb 17, 2022
@wg102
Copy link
Contributor Author

wg102 commented Feb 18, 2022

Is this something we want:
image

@wg102
Copy link
Contributor Author

wg102 commented Mar 3, 2022

Things to fix:
image

  • No default language

  • No i18n
    image

  • Text not showing
    image

  • No negative validation
    image

  • no i18n
    image

  • No validation for used volumes

  • no i18n
    image

  • no i18n

  • No icons on any of the tables

  • Tooltip on Notebook Server Table not working

@wg102
Copy link
Contributor Author

wg102 commented Aug 10, 2022

This was finished in April

@wg102 wg102 closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic Tracks related issues; has no size
Projects
None yet
Development

No branches or pull requests

1 participant