From 044adb96d6ba4f7b3cd2c595ccc555424550959e Mon Sep 17 00:00:00 2001
From: Bryan Paget <8212170+bryanpaget@users.noreply.github.com>
Date: Wed, 24 Jan 2024 14:24:25 +0000
Subject: [PATCH] update(blobcsi): fdi container setup

---
 docs/dev/features/object-storage/blobcsi.md | 53 ++++++++++++---------
 1 file changed, 30 insertions(+), 23 deletions(-)

diff --git a/docs/dev/features/object-storage/blobcsi.md b/docs/dev/features/object-storage/blobcsi.md
index d46020df8..5a9b5ab6e 100644
--- a/docs/dev/features/object-storage/blobcsi.md
+++ b/docs/dev/features/object-storage/blobcsi.md
@@ -165,16 +165,13 @@ resource "kubernetes_secret" "aaw-<acronym>-prod-sp-secret" {
 
 #### c. Add bucket info:
 
-
-Add the following to `resource "kubectl_manifest" "fdi-aaw-configuration-data"`, in one of:
+Add the following to `resource "kubectl_manifest" "fdi-aaw-configuration-data"`, in one of the following, depending on the classification of the bucket:
 
 1. `fdi-protected-b-external.json: |` or 
 2. `fdi-unclassified-external.json: |` or
 3. `fdi-protected-b-internal.json: |` or
 4. `fdi-unclassified-internal.json: |`
 
-depending on the classification of the bucket.
-
 ```   
       {
               "bucketName": "<should-be-provided-for-you>",
@@ -183,25 +180,32 @@ depending on the classification of the bucket.
               "readers":    ["<name-of-kuebeflow-profile>"],
               "writers":    ["<name-of-kuebeflow-profile>"],
               "spn": "aaw-<acronym>-prod-sp"
-      },
-      {
-              "bucketName": "<should-be-provided-for-you>-transit",
-              "pvName":     "<acronym>-inbox-eprotb",
-              "subfolder":  "from-de",
-              "readers":    ["<name-of-kuebeflow-profile>"],
-              "writers":    ["<name-of-kuebeflow-profile>"],
-              "spn": "aaw-<acronym>-prod-sp"
-      },
-      {
-              "bucketName": "<should-be-provided-for-you>-transit",
-              "pvName":     "<acronym>-outbox-eprotb",
-              "subfolder":  "to-vers",
-              "readers":    ["<name-of-kuebeflow-profile>"],
-              "writers":    ["<name-of-kuebeflow-profile>"],
-              "spn": "aaw-<acronym>-prod-sp"
       }
 ```
 
+##### Transit Folders
+
+If the storage solution requires transit containers, you'll want to add this as well. Not all solutions require this.
+
+```
+{
+  "bucketName":  "<should-be-provided-for-you>-transit",
+  "pvName": "<acronym>-inbox-eprotb",
+  "subfolder": "from-de",
+  "readers": ["<name-of-kuebeflow-profile>"],
+  "writers": ["<name-of-kuebeflow-profile>"],
+  "spn": "aaw-<acronym>-prod-sp"
+},
+{
+  "bucketName": "<should-be-provided-for-you>-transit",
+  "pvName": "<acronym>-outbox-eprotb",
+  "subfolder": "to-vers",
+  "readers": ["<name-of-kuebeflow-profile>"],
+  "writers": ["<name-of-kuebeflow-profile>"],
+  "spn": "aaw-<acronym>-prod-sp"
+}
+```
+
 ##### Info
 
 > `bucketName:` should be given to you by the person requesting the bucket.
@@ -214,19 +218,22 @@ depending on the classification of the bucket.
 > 
 > `writers:` use the kubeflow profile name for this
 > 
-> `spn:` this has to be created by YOU. Send a JIRA ticket to the Cloud Team.
+> `spn:` this has to be obtained by yo by sending a Jira ticket to the Cloud Team. See below for an example SPN request.
 > 
 
 ##### Example Cloud Ticket
 
+To obtain the SPN, send a Jira ticket to the Cloud Team, follow the template below:
+
 > Hi,
 >
 > Can I get a service principle named aaw-\<acronym\>-prod-sp created please?
 >
 > The owners should be:
 >
-> relevant.person.one@cloud.statcan.ca
-> relevant.person.two@cloud.statcan.ca
+> - relevant.person.one@cloud.statcan.ca
+> - relevant.person.two@cloud.statcan.ca
+> 
 > More info: https://jirab.statcan.ca/browse/?????-????
 >
 > Thanks!