Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] graceful websockets closures displays as errors #1916

Closed
kn0wmad opened this issue Nov 8, 2022 · 1 comment
Closed

[bug] graceful websockets closures displays as errors #1916

kn0wmad opened this issue Nov 8, 2022 · 1 comment
Assignees
@dr-bonez
Labels
Bug Something isn't working startd Issues pertaining to startd itself
Milestone
0.3.3

Comments

@kn0wmad
Copy link
Contributor

kn0wmad commented Nov 8, 2022 •
edited
Loading

image

No symptoms during this occurrence
v033, Embassy Pro

Don't log as an error if websocket closed in an unexpected way?
@kn0wmad kn0wmad added Bug Something isn't working startd Issues pertaining to startd itself labels Nov 8, 2022
@kn0wmad kn0wmad assigned dr-bonez and unassigned MattDHill Nov 8, 2022
@MattDHill MattDHill added this to the 0.3.3 milestone Nov 9, 2022
@MattDHill MattDHill moved this to Todo in eOS 0.3.3 Nov 9, 2022
@MattDHill
Copy link
Member

This ticket is less about the frequency of closing websockets and more about the closures logging as errors. If a websocket closes gracefully, it should not display as an error.

@MattDHill MattDHill changed the title [bug] WebSockets Close Often [bug] graceful websockets closures displays as errors Nov 9, 2022
@dr-bonez dr-bonez moved this from Todo to In Progress in eOS 0.3.3 Nov 27, 2022
@dr-bonez dr-bonez mentioned this issue Nov 27, 2022
Merged
@dr-bonez dr-bonez moved this from In Progress to Code Review in eOS 0.3.3 Nov 27, 2022
@MattDHill MattDHill moved this from Code Review to UAT in eOS 0.3.3 Nov 28, 2022
Repository owner moved this from UAT to Done in eOS 0.3.3 Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr-bonez dr-bonez

Labels
Bug Something isn't working startd Issues pertaining to startd itself
Projects
No open projects
eOS 0.3.3
Status: Done
Milestone
0.3.3
Development

No branches or pull requests
3 participants
@dr-bonez @MattDHill @kn0wmad