Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Out of Memory Error notifications #1002

Open
1 task done
Blu-J opened this issue Dec 27, 2021 · 6 comments
Open
1 task done

[feat]: Out of Memory Error notifications #1002

Blu-J opened this issue Dec 27, 2021 · 6 comments
Assignees
Labels
Enhancement New feature or request P3 - Eventual Things of low consequence to ignore startd Issues pertaining to startd itself

Comments

@Blu-J
Copy link
Contributor

Blu-J commented Dec 27, 2021

Prerequisites

  • I have searched for existing issues that already suggest this feature, without success.

Describe the Feature Request

This is an improvement upon the description coming from the os + docker describing that a service was killed because of the out of memory

Describe the Use Case

So, given that we have a bitcoind and we may give it too much memory, we want to know that the system is being restarted because of memory out instead of what the OS is giving. So this is a server UI around the crashing because of memory out.

Describe Preferred Solution

From the error code indicate that this was a out of memory kill.,

Describe Alternatives

No response

Anything else?

No response

@Blu-J Blu-J added the Enhancement New feature or request label Dec 27, 2021
@dr-bonez dr-bonez added P2 - Desirable high prioity, nice-to-haves startd Issues pertaining to startd itself labels Dec 28, 2021
@dr-bonez dr-bonez added this to the 0.3.0 milestone Dec 28, 2021
@dr-bonez
Copy link
Member

Ok, so it turns out the exit code for running out of memory is the same exit code used for any application terminated by SIGKILL. Looking for other ways to differentiate.

@ProofOfKeags
Copy link
Contributor

Usually the only reason the OS will send an unprompted SIGKILL is for OOM.

@dr-bonez
Copy link
Member

docker will send a sigkill if a sigterm times out

@chrisguida
Copy link
Contributor

sigterm is only sent by embassyd though, not the base os

@ProofOfKeags
Copy link
Contributor

ProofOfKeags commented Dec 30, 2021

docker will send a sigkill if a sigterm times out

so all we need to do is pair stop requests with signals.

All signals that don't have a stop request are OOM issues.

@MattDHill MattDHill removed this from the 0.3.0 milestone Mar 1, 2022
@elvece elvece added P3 - Eventual Things of low consequence to ignore and removed P2 - Desirable high prioity, nice-to-haves labels Dec 14, 2022
@chrisguida
Copy link
Contributor

Aiden notes that docker figures this out somehow, we should figure out what that is and duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request P3 - Eventual Things of low consequence to ignore startd Issues pertaining to startd itself
Projects
None yet
Development

No branches or pull requests

6 participants