Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecondsFormatterMixin:FormatZero ignores the formatters own convertToLower setting #706

Open
ndunsworth opened this issue Feb 19, 2025 · 0 comments

Comments

@ndunsworth
Copy link

Current Impl

function SecondsFormatterMixin:FormatZero(abbreviation, toLower)
	local minInterval = self:GetMinInterval(seconds);
	local formatString = self:GetFormatString(minInterval, abbreviation);
	return formatString:format(0);
end

Expected Impl

function SecondsFormatterMixin:FormatZero(abbreviation, toLower)
	local minInterval = self:GetMinInterval(seconds);
	local formatString = self:GetFormatString(minInterval, abbreviation, self.convertToLower);
	return formatString:format(0);
end

This causes MySecondsFormatter:Format(0) to return "0 Sec" when initialized as MySecondsFormatter:Init(1, SecondsFormatter.Abbreviation.Truncate, false, true, true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant