Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Russian language translation #903

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

StepanLebedevTheodo
Copy link
Contributor

Description

  • Adds Russian language translation to Quivr
  • Fixes some missing translations
  • Fixes copy past error in English version

@StepanLebedevTheodo StepanLebedevTheodo temporarily deployed to preview August 9, 2023 08:30 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 8:39am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 8:39am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/NavBar/components/NavItems/components/LanguageDropDown/hooks/useLanguageHook.ts

The changes in this file are related to the addition of new languages and the implementation of a hook to handle language changes. However, there is a potential issue with the use of localStorage for storing the selected language. If the user has disabled localStorage or it is not available, this could cause an error. Consider adding a check for the availability of localStorage before using it. For example:

if (typeof window !== 'undefined' && window.localStorage) {
  // use localStorage
}

🌐🔧⚠️


Powered by Code Review GPT

@StepanLebedevTheodo StepanLebedevTheodo merged commit 672eec0 into main Aug 9, 2023
@StepanLebedevTheodo StepanLebedevTheodo deleted the feat/russian-language branch August 9, 2023 09:17
StanGirard pushed a commit that referenced this pull request Sep 12, 2023
* feat(Russian Translation): Adds Russian Language option

* fix: Corrects Failedtofetch field in English Version

* fix: Adds missing translations on upload page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants