Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings partially lost if both timer and view settings are changed #27

Closed
letmaik opened this issue Sep 1, 2018 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@letmaik
Copy link
Contributor

letmaik commented Sep 1, 2018

Looking at the source code of Timer.js and View.js, both storage modules create a LocalStore object where the data is read from a JSON configuration file on disk. Since those objects are independent, changing options from both tabs will loose any changes from the tab that was edited first. E.g. first I change the work timer to 20min, and then I disable desktop notifications. After restarting the app, the work timer change is lost.

@Splode Splode added the bug Something isn't working label Oct 10, 2018
@Splode
Copy link
Owner

Splode commented Feb 1, 2019

Fixed with b42e5c2. Thanks 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants