Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization #37

Open
2 of 5 tasks
TechnoGeek01 opened this issue Feb 1, 2024 · 0 comments
Open
2 of 5 tasks

Optimization #37

TechnoGeek01 opened this issue Feb 1, 2024 · 0 comments

Comments

@TechnoGeek01
Copy link
Contributor

TechnoGeek01 commented Feb 1, 2024

  • Wherever there is a "if" statement that doesn't contain "else" statement, we can simplify it into a single line without the curly braces. To add a note, it might make sense to keep it otherwise in certain places.
  • Need to reconsider our function naming conventions. For example, _isTokenManager(address _rwdToken) in BaseFarm.sol seems as if it returns a bool but actually it reverts on a specific condition.
  • We need to explore a concept called "Test Harnesses" for testing internal functions using foundry.
  • Test case optimization #41 (comment)
  • Use either named returns or normal returns. Don't use both in a single function as its redundant. Also use the same pattern across all the contracts for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant