You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wherever there is a "if" statement that doesn't contain "else" statement, we can simplify it into a single line without the curly braces. To add a note, it might make sense to keep it otherwise in certain places.
Need to reconsider our function naming conventions. For example, _isTokenManager(address _rwdToken) in BaseFarm.sol seems as if it returns a bool but actually it reverts on a specific condition.
We need to explore a concept called "Test Harnesses" for testing internal functions using foundry.
Use either named returns or normal returns. Don't use both in a single function as its redundant. Also use the same pattern across all the contracts for consistency.
The text was updated successfully, but these errors were encountered:
The text was updated successfully, but these errors were encountered: