No error is returned in controller

[felixkwasisarpong]

Versions

• PHP version: 7.1.18
• Laravel version: 5.7.13
• Package version: 3.1.3

Description
I'm working on an Import class that uses concerns WithHeadingRow and WithValidation. I've copied the try/catch in the docs for gathering failures, but the no error is generated even though the excel contains an error.However the onFailure function throws the errors.
Steps to Reproduce
Relevant controller code:

        $import = new CustomersImport;         
          try { 
            $import->import($file);
          } catch (\Maatwebsite\Excel\Validators\ValidationException $e) 
          { 
            $failures = $e->failures();

            foreach ($failures as $failure) {
                $failure->row(); // row that went wrong
                $failure->attribute(); // either heading key (if using heading row concern) or column index
                $failure->errors(); // Actual error messages from Laravel validator
                $failure->values(); // The values of the row that has failed.
              logger($failures);
                
            }
          }

Relevant import class code:

    {
         $this->failures = array_merge($this->failures, $failures);
    
        return   $this->failures;
    }
    
    public function failures($failures)
    {
       
        return $this->failures;
    }

[patrickbrouwers]

I've already replied to your previous question: #3182 I'd prefer to keep the related questions in 1 thread, thanks.

If you follow the documentation correctly, you'll see that if yo use skip failures doesn't need to try catch. Please have another look at the link I shared yesterday: https://docs.laravel-excel.com/3.1/imports/validation.html#skipping-errors

[felixkwasisarpong]

I have updated the information.

[patrickbrouwers]

If you use ShouldQueue you can't get the errors in the controller

[felixkwasisarpong]

My problem is, I'm able to get the errors but the rows without errors doesn't get inserted into the database

[patrickbrouwers]

Not sure, you'll have to try and debug it yourself. I've both (package) unit tests as own applications running on similar code and working fine.

[felixkwasisarpong]

Okay..Thanks

[felixkwasisarpong]

How can I add onSkipfailures and also catch errors in controller since that's what i want to achieve.

[patrickbrouwers]

I'll share the link again: https://docs.laravel-excel.com/3.1/imports/validation.html#skipping-failures