Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soundnode song status like button disappears on pause #722

Closed
grant-h opened this issue Apr 4, 2016 · 6 comments
Closed

Soundnode song status like button disappears on pause #722

grant-h opened this issue Apr 4, 2016 · 6 comments

Comments

@grant-h
Copy link

grant-h commented Apr 4, 2016

While the current song is playing this is visible

screen shot 2016-04-04 at 3 26 31 pm

after pausing this is what I see

screen shot 2016-04-04 at 3 26 42 pm

I believe that the like button should be visible at all times. This is slightly related to #709 in that the bottom like button has some state issues.

I believe the most relevant lines are here:

<div class="player_actions">
<span class="player_favorite" ng-click="favorite($event)" ng-hide="!isSongPlaying">
&nbsp;<i class="fa fa-heart"></i>
</span>
</div>

@grant-h
Copy link
Author

grant-h commented Apr 4, 2016

Based on the code <span class="player_favorite" ng-click="favorite($event)" ng-hide="!isSongPlaying"> it seems like this was meant as a feature. Not sure I feel that way, but open to opinions.

@weblancaster
Copy link
Member

Yes we did on purpose @grant-h but now we should do it the right way.

@grant-h
Copy link
Author

grant-h commented Apr 4, 2016

@weblancaster Thanks for the response! Would you like me to submit a PR or should I let you handle it?

@weblancaster
Copy link
Member

Feel free do contribute @grant-h the only thing is that we are going to review and test your code.

@weblancaster
Copy link
Member

What need to be done here isn't just to always display the "heart" but for each song playing we should check if that song was liked before and mark if so.

@weblancaster
Copy link
Member

This is fixed and will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants