-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soundnode song status like button disappears on pause #722
Comments
Based on the code |
Yes we did on purpose @grant-h but now we should do it the right way. |
@weblancaster Thanks for the response! Would you like me to submit a PR or should I let you handle it? |
Feel free do contribute @grant-h the only thing is that we are going to review and test your code. |
What need to be done here isn't just to always display the "heart" but for each song playing we should check if that song was liked before and mark if so. |
This is fixed and will be available in the next release. |
While the current song is playing this is visible
after pausing this is what I see
I believe that the like button should be visible at all times. This is slightly related to #709 in that the bottom like button has some state issues.
I believe the most relevant lines are here:
soundnode-app/app/index.html
Lines 152 to 156 in 9e60387
The text was updated successfully, but these errors were encountered: