Fix S2583 FP: Should not raise on double condition #8475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/SE-Double
branch
from
4a59d6f
to
519a4c5
Compare
pavel-mikula-sonarsource
requested a review
from cristian-ambrosini-sonarsource
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Binary.cs
Show resolved
Hide resolved
cristian-ambrosini-sonarsource
suggested changes
Dec 19, 2023
There was a problem hiding this comment.
Left few comments, half of my brain is fried because of #8484 so I might have missed something, I would like to take another look tomorrow
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Binary.cs
Show resolved
Hide resolved
pavel-mikula-sonarsource
force-pushed
the
Pavel/SE-Double
branch
from
09d9f0c
to
2198360
Compare
|
|
pavel-mikula-sonarsource
requested a review
from cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8470