Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2583 FP: Variable Set in Catch Block #8444

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix S2583 FP: Variable Set in Catch Block #8444

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
640d55f
Enable the SE engine to explore exception paths for division operations
Tim-Pohlmann Dec 6, 2023
6a542ed
Review 1
Tim-Pohlmann Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/ExceptionCandidate.cs
View file
Open in desktop
zsolt-kolbay-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,20 @@ public ExceptionCandidate(Compilation compilation) =>
public ExceptionState FromOperation(ProgramState state, IOperationWrapperSonar operation) =>
operation.Instance.Kind switch
{
OperationKindEx.ArrayElementReference => FromOperation(IArrayElementReferenceOperationWrapper.FromOperation(operation.Instance)),
OperationKindEx.ArrayElementReference => FromOperation(operation.Instance.ToArrayElementReference()),
OperationKindEx.Conversion => FromConversion(operation),
OperationKindEx.DynamicIndexerAccess => new ExceptionState(typeCatalog.SystemIndexOutOfRangeException),
OperationKindEx.DynamicInvocation => ExceptionState.UnknownException, // This raises is Microsoft.CSharp.RuntimeBinder.RuntimeBinderException that we can't access.
OperationKindEx.DynamicMemberReference => ExceptionState.UnknownException, // This raises is Microsoft.CSharp.RuntimeBinder.RuntimeBinderException that we can't access.
OperationKindEx.DynamicObjectCreation => ExceptionState.UnknownException, // This raises is Microsoft.CSharp.RuntimeBinder.RuntimeBinderException that we can't access.
OperationKindEx.EventReference => FromOperation(state, IMemberReferenceOperationWrapper.FromOperation(operation.Instance)),
OperationKindEx.FieldReference => FromOperation(state, IMemberReferenceOperationWrapper.FromOperation(operation.Instance)),
OperationKindEx.Invocation => FromOperation(IInvocationOperationWrapper.FromOperation(operation.Instance)),
OperationKindEx.MethodReference => FromOperation(state, IMemberReferenceOperationWrapper.FromOperation(operation.Instance)),
OperationKindEx.EventReference => FromOperation(state, operation.Instance.ToMemberReference()),
OperationKindEx.FieldReference => FromOperation(state, operation.Instance.ToMemberReference()),
OperationKindEx.Invocation => FromOperation(operation.Instance.ToInvocation()),
OperationKindEx.MethodReference => FromOperation(state, operation.Instance.ToMemberReference()),
OperationKindEx.ObjectCreation => operation.Instance.Type.DerivesFrom(KnownType.System_Exception) ? null : ExceptionState.UnknownException,
OperationKindEx.PropertyReference => FromOperation(state, IMemberReferenceOperationWrapper.FromOperation(operation.Instance)),
OperationKindEx.PropertyReference => FromOperation(state, operation.Instance.ToMemberReference()),
OperationKindEx.Binary => FromOperation(operation.Instance.ToBinary()),
OperationKindEx.CompoundAssignment => FromOperation(operation.Instance.ToCompoundAssignment()),
_ => null
};

Expand Down Expand Up @@ -80,4 +82,17 @@ private static ExceptionState FromOperation(IInvocationOperationWrapper invocati
|| invocation.IsLockRelease() // Needed by S2222
? null
: ExceptionState.UnknownException;

private static ExceptionState FromOperation(IBinaryOperationWrapper binary) =>
IsDivision(binary.OperatorKind)
? ExceptionState.UnknownException // This raises is System.DivideByZeroException that we can't access.
zsolt-kolbay-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
: null;

private static ExceptionState FromOperation(ICompoundAssignmentOperationWrapper compoundAssignment) =>
IsDivision(compoundAssignment.OperatorKind)
? ExceptionState.UnknownException // This raises is System.DivideByZeroException that we can't access.
: null;

private static bool IsDivision(BinaryOperatorKind operatorKind) =>
operatorKind is BinaryOperatorKind.Divide or BinaryOperatorKind.Remainder or BinaryOperatorKind.IntegerDivide;
}
3 changes: 3 additions & 0 deletions ...zers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/Extensions/IOperationExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ internal static IFlowCaptureReferenceOperationWrapper ToFlowCaptureReference(thi
internal static ILocalReferenceOperationWrapper ToLocalReference(this IOperation operation) =>
ILocalReferenceOperationWrapper.FromOperation(operation);

internal static IMemberReferenceOperationWrapper ToMemberReference(this IOperation operation) =>
IMemberReferenceOperationWrapper.FromOperation(operation);

internal static IMethodReferenceOperationWrapper ToMethodReference(this IOperation operation) =>
IMethodReferenceOperationWrapper.FromOperation(operation);

Expand Down
2 changes: 1 addition & 1 deletion ...SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3407,7 +3407,7 @@ public void Method()
{
success = false;
}
if (success) // Noncompliant FP
if (success) // Compliant
{
Console.WriteLine("Success!");
}
Expand Down
Loading