S2589: Add repros #8014
Merged
S2589: Add repros #8014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gregory-paidis-sonarsource
commented
Sep 14, 2023
gregory-paidis-sonarsource
commented
- Repro for S2589 FP: Rule is raised on catch-all tuples in switch expressions #8008
- Repro for S2589 FP: Rule is erroneously raised on var-type pattern matches that use when clauses #8011
gregory-paidis-sonarsource
requested a review
from mary-georgiou-sonarsource
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned gregory-paidis-sonarsource
| { | ||
| return flags switch | ||
| { | ||
| var value when value.HasFlag(Flags.Foo) => 1, // Noncompliant FP |
There was a problem hiding this comment.
Please assert also the message for these issues.
It will speed up our understanding upon tackling it.
| { | ||
| public int? Age { get; set; } | ||
| } | ||
| // ... |
There was a problem hiding this comment.
nitpick: just line break here is enough.
Suggested change
| // ... |
mary-georgiou-sonarsource
approved these changes
Sep 14, 2023
github-actions
bot
assigned gregory-paidis-sonarsource and unassigned mary-georgiou-sonarsource
This was referenced Sep 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.