Fix S4027 FP: BinaryFormatter. Serialization constructors are obsolete and should not be required

[martin-strecker-sonarsource]

Description

In .net 8 "All externally visible (public or protected) serialization ctors: .ctor(SerializationInfo, StreamingContext)." are marked as obsolete (Source).

We need to remove the serialization constructor from the list of required constructors for exceptions.

Repro steps

public class MyException : Exception
{
      public MyException() { }

      public MyException(string message)
          :base(message) { }

      public MyException(string message, Exception innerException)
          : base(message, innerException) { }

      protected MyException(SerializationInfo info, StreamingContext context) // <- SYSLIB0051 
          : base(info, context) { }
}

Expected behavior

The serialization constructor should not be mandatory.

Actual behavior

A missing serialization constructor raises S4027.

Todos:

• Remove the serialization constructor from the list of required constructors Fix S4027 FP: BinaryFormatter. Serialization constructors are obsolete and should not be required #8563
• Serialization constructors are still allowed but are optional now Fix S4027 FP: BinaryFormatter. Serialization constructors are obsolete and should not be required #8563
• Update RSpec

Known workarounds

Suppress S4027

See also

#8377