Fix S2583 FP: Variable Set in Catch Block

[groogiam]

Description

S2583 FP Variable Set in Catch Block

Repro steps

var success = true;
try
{
    var result = 100 / DateTime.Now.Second;
}
catch (Exception ex)
{
    success = false;
}
if (success) // FP
{
    Console.WriteLine("Success!");
}

Expected behavior

S2583 should not trigger at success if statement.

Actual behavior

S2583 is triggered at success if statement.

Known workarounds

Please provide a description of any known workarounds.

Related information

• C#/VB.NET Plugins version Sonarlint 7.4.0.80741
• Visual Studio version 17.8.0
• MSBuild / dotnet version 8.0.100
• SonarScanner for .NET version (if used)
• Operating System Windows 10

[Tim-Pohlmann]

Hi @groogiam thanks for the report!
I confirm this as an FP. I simplified the example a bit. The problem is, that the analyzer treats the division as a safe operation (which is wrong). We will improve this in the future.

[groogiam]

@Tim-Pohlmann Has this been released in Sonar Lint? I'm still seeing similar false positives to this in my code. Thanks.

[Tim-Pohlmann]

@groogiam Not yet. It should be in the next release. You can track the relevant issue here.
Alternatively, you can download the newest analyzer (which already contains the fix) directly from Nuget.