From e1cf273a5790708a446157c612c0d17900c5a31a Mon Sep 17 00:00:00 2001 From: Victor Date: Thu, 16 Nov 2023 11:46:19 +0100 Subject: [PATCH 1/2] Remove references from React no-deprecated messages --- packages/jsts/src/rules/S1874/rule.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/jsts/src/rules/S1874/rule.ts b/packages/jsts/src/rules/S1874/rule.ts index 64d4b02f75..470579af33 100644 --- a/packages/jsts/src/rules/S1874/rule.ts +++ b/packages/jsts/src/rules/S1874/rule.ts @@ -29,7 +29,10 @@ const reactNoDeprecated = rules['no-deprecated']; export const rule: Rule.RuleModule = { meta: { - messages: { ...reactNoDeprecated.meta!.messages, ...diagnosticsRule.meta!.messages }, + messages: { + deprecated: '{{oldMethod}} is deprecated since React {{version}}{{newMethod}}', + ...diagnosticsRule.meta!.messages, + }, }, create(context: Rule.RuleContext) { function getVersionFromOptions() { From 38262217739d0d3c8a81fa36b238bceec2c668d6 Mon Sep 17 00:00:00 2001 From: Victor Date: Thu, 16 Nov 2023 12:09:06 +0100 Subject: [PATCH 2/2] add assertion for new message --- packages/jsts/src/rules/S1874/cb.react.fixture.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/jsts/src/rules/S1874/cb.react.fixture.tsx b/packages/jsts/src/rules/S1874/cb.react.fixture.tsx index 7bfe411c6e..bc368fcc1f 100644 --- a/packages/jsts/src/rules/S1874/cb.react.fixture.tsx +++ b/packages/jsts/src/rules/S1874/cb.react.fixture.tsx @@ -2,7 +2,7 @@ import React, { PropTypes, Component } from 'react'; // Noncompliant // ^^^^^^^^^ import ReactDOM from 'react-dom'; -React.render(, root); // Noncompliant +React.render(, root); // Noncompliant {{React.render is deprecated since React 0.14.0, use ReactDOM.render instead}} React.unmountComponentAtNode(root); // Noncompliant