Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: snowflake_user_ownership_grant resource #969

Merged
merged 5 commits into from
Apr 11, 2022

Conversation

aidanmelen
Copy link
Contributor

@aidanmelen aidanmelen commented Apr 10, 2022

Test Plan

  • acceptance tests
$ make test
goimports -w -d $(find . -type f -name '*.go' -not -path "./vendor/*" -not -path "./dist/*")
go mod tidy -compat=1.17
CGO_ENABLED=1 go test -race -coverprofile=coverage.txt -covermode=atomic  ./...
?       github.com/chanzuckerberg/terraform-provider-snowflake  [no test files]
ok      github.com/chanzuckerberg/terraform-provider-snowflake/pkg/datasources  0.199s  coverage: 4.1% of statements
?       github.com/chanzuckerberg/terraform-provider-snowflake/pkg/db   [no test files]
ok      github.com/chanzuckerberg/terraform-provider-snowflake/pkg/provider     0.367s  coverage: 30.4% of statements
ok      github.com/chanzuckerberg/terraform-provider-snowflake/pkg/resources    10.882s coverage: 55.2% of statements
ok      github.com/chanzuckerberg/terraform-provider-snowflake/pkg/snowflake    0.104s  coverage: 59.1% of statements
?       github.com/chanzuckerberg/terraform-provider-snowflake/pkg/testhelpers  [no test files]
ok      github.com/chanzuckerberg/terraform-provider-snowflake/pkg/validation   0.045s  coverage: 93.1% of statements
?       github.com/chanzuckerberg/terraform-provider-snowflake/pkg/version      [no test files]

$ make test-acceptance TESTARGS='-run=TestAccUserOwnershipGrant_defaults'
goimports -w -d $(find . -type f -name '*.go' -not -path "./vendor/*" -not -path "./dist/*")
go mod tidy -compat=1.17
SKIP_MANAGED_ACCOUNT_TEST=1 TF_ACC=1 go test -v -coverprofile=coverage.txt -covermode=atomic -run=TestAccUserOwnershipGrant_defaults ./...
?       github.com/chanzuckerberg/terraform-provider-snowflake  [no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/chanzuckerberg/terraform-provider-snowflake/pkg/datasources  0.033s  coverage: 0.0% of statements [no tests to run]
?       github.com/chanzuckerberg/terraform-provider-snowflake/pkg/db   [no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/chanzuckerberg/terraform-provider-snowflake/pkg/provider     0.059s  coverage: 0.0% of statements [no tests to run]
=== RUN   TestAccUserOwnershipGrant_defaults
=== PAUSE TestAccUserOwnershipGrant_defaults
=== CONT  TestAccUserOwnershipGrant_defaults
--- PASS: TestAccUserOwnershipGrant_defaults (10.58s)
PASS
coverage: 4.2% of statements
ok      github.com/chanzuckerberg/terraform-provider-snowflake/pkg/resources    10.636s coverage: 4.2% of statements
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/chanzuckerberg/terraform-provider-snowflake/pkg/snowflake    0.016s  coverage: 0.0% of statements [no tests to run]
?       github.com/chanzuckerberg/terraform-provider-snowflake/pkg/testhelpers  [no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/chanzuckerberg/terraform-provider-snowflake/pkg/validation   0.013s  coverage: 0.0% of statements [no tests to run]
?       github.com/chanzuckerberg/terraform-provider-snowflake/pkg/version      [no test files]

References

@aidanmelen
Copy link
Contributor Author

@alldoami this should be ready for review. tests pass and generated docs.

@aidanmelen aidanmelen changed the title init snowflake_user_ownership_grant add snowflake_user_ownership_grant resource Apr 10, 2022
@alldoami alldoami changed the title add snowflake_user_ownership_grant resource feat: add snowflake_user_ownership_grant resource Apr 11, 2022
@alldoami alldoami changed the title feat: add snowflake_user_ownership_grant resource feat snowflake_user_ownership_grant resource Apr 11, 2022
@alldoami alldoami changed the title feat snowflake_user_ownership_grant resource feat: snowflake_user_ownership_grant resource Apr 11, 2022
@alldoami
Copy link
Contributor

/ok-to-test sha=fb8f4a4

@github-actions
Copy link

Integration tests success for fb8f4a4

@alldoami alldoami merged commit 6f3f09d into Snowflake-Labs:main Apr 11, 2022
@aidanmelen aidanmelen deleted the user_ownership_grant branch February 25, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants