Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow legacy version of GrantIDs to be used with new grant functionality #923

Merged

Conversation

daniepett
Copy link
Contributor

@daniepett daniepett commented Mar 14, 2022

Allowing for legacy length/structure of GrantIDs to be used with the new multiple grants functionality. Role names in GrantIDs are not used for anything but uniqueness of the IDs.

IDs will be created with the new structure whenever resources are dropped and recreated, and it will be invisible to the end user.

Test Plan

  • acceptance tests
  • unit tests

References

@daniepett daniepett changed the title fix: Allow legacy version of Role GrantIDs to be used with new grant setup fix: Allow legacy version of GrantIDs to be used with new grant functionality Mar 14, 2022
@alldoami
Copy link
Contributor

/ok-to-test sha=807dae1

@github-actions
Copy link

Integration tests success for 807dae1

@jaeglee0416
Copy link

I wonder if the fix should have been >= 1 on number of fields (for role grants to other roles).

https://registry.terraform.io/providers/chanzuckerberg/snowflake/latest/docs/resources/role_grants

There is only one "required" field role_name.
We're now running into issues with 4 to 6 fields allowed in ID

Same comment as: #921 (comment)

daniepett added a commit to daniepett/terraform-provider-snowflake that referenced this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants