Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Shares can't be updated on table_grant resource #789

Merged
merged 7 commits into from
Dec 16, 2021
Merged

Fix: Shares can't be updated on table_grant resource #789

merged 7 commits into from
Dec 16, 2021

Conversation

chriskuchin
Copy link
Contributor

The difference function in the table_grant resource had a hard coded string meaning it only ever calculated the difference for roles not shares.

@chriskuchin
Copy link
Contributor Author

@alldoami would love any guidance to get this incorporated as soon as possible. Let me know if you would like to see anything more on this seems pretty straightforward to me

@alldoami
Copy link
Contributor

/ok-to-test sha=261001c

@alldoami alldoami self-requested a review December 16, 2021 00:20
@github-actions
Copy link

Integration tests success for 261001c

@alldoami
Copy link
Contributor

Would be great if you could add a test here! https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/main/pkg/resources/external_table_grant_test.go

@chriskuchin
Copy link
Contributor Author

@alldoami I am a little confused does the external table grant use the table_grant?

@chriskuchin
Copy link
Contributor Author

@alldoami I added a test to table_grant_test.go I have verified that it fails when bug is present. Assumed this is what you wanted above. Let me know if there is anything else needed here.

@alldoami
Copy link
Contributor

/ok-to-test sha=fac1c94

@alldoami
Copy link
Contributor

Thank you for adding the test! It looks good.

@github-actions
Copy link

Integration tests success for fac1c94

@alldoami alldoami merged commit 6884748 into Snowflake-Labs:main Dec 16, 2021
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
@chriskuchin
Fix: Shares can't be updated on table_grant resource (Snowflake-Labs#789
26b68d1 
)
@snowflake-release-please snowflake-release-please bot mentioned this pull request May 25, 2022
Merged
This was referenced Nov 1, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alldoami alldoami alldoami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriskuchin @alldoami