-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add AWS_SNS notification_provider support for error notifications for Snowpipe. #777
Conversation
Please run |
Error notifications feature is currently in private preview link reference here and Snowflake staff need to enable it for that particular account before setting error_integration parameter would work. |
Docs re-generated |
@alldoami, I believe I finally fixed all the issues. I was able to run make test successfully. Please approve the Github Actions |
/ok-to-test sha=3a447b5 |
Integration tests success for 3a447b5 |
Context
I am adding AWS SNS notification_provider support for error notifications for Snowpipe. The current Snowflake provider version supports this feature; however, it supports an outdated version of it that was using SQS. My goal is to adapt the current provider to support SNS instead of SQS and thus stay up to date with the Snowflake feature. The documentation link for the new Snowflake feature could be found here
Please keep some things in mind:
What I have tried to do (but does not seem to pass the tests)
I took reference of PR [595] which essentially does the same thing I want to do but using SQS instead of SNS.
However, I get the following errors when I try to run the test using
make
like:What am I doing wrong that makes the tests fail? Am I on the right track?
Happy to include further information if needed : )