Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Row Access Policy Resources #624

Merged

Conversation

ChrisIsidora
Copy link
Contributor

@ChrisIsidora ChrisIsidora commented Jul 28, 2021

Implemented Row Access Policy:

  • Row Access Policies Datasource
  • Row Access Policy Resource
  • Row Access Policy Grant Resource

Resolves #615

Test Plan

  • acceptance tests
  • unit tests

References

@ChrisIsidora ChrisIsidora requested a review from a team as a code owner July 28, 2021 11:31
@ChrisIsidora
Copy link
Contributor Author

@alldoami Can you also review this one? Thanks in advance

@ChrisIsidora
Copy link
Contributor Author

@alldoami Can this also be merged?

@alldoami
Copy link
Contributor

Could you fix the conflicts @ChrisIsidora ?

@ChrisIsidora
Copy link
Contributor Author

@alldoami Done! After the tests are successful, is it possible to make a new version or do I have to wait till Tuesday (CEST)?

@alldoami
Copy link
Contributor

/ok-to-test sha=4f181a9

@alldoami
Copy link
Contributor

I can release a new version after we merge this today! @ChrisIsidora

@github-actions
Copy link

Integration tests success for 4f181a9

@alldoami alldoami merged commit fd97816 into Snowflake-Labs:main Jul 31, 2021
@alldoami
Copy link
Contributor

Ah I'm having trouble releasing 😓 Getting

⨯ release failed after 251.52s error=failed to build for solaris_amd64: exit status 2: # github.com/pkg/browser
../go/pkg/mod/github.com/pkg/browser@v0.0.0-20210706143420-7d21f8c997e2/browser_unsupported.go:7:2: imported and not used: "os/exec"

even after upgrading go...

@ChrisIsidora
Copy link
Contributor Author

ChrisIsidora commented Jul 31, 2021

@alldoami Is it possible to just remove that package/module? Because it doesn't seems to be used

@ChrisIsidora ChrisIsidora deleted the feature/add-row-access-policies branch July 31, 2021 06:36
@alldoami
Copy link
Contributor

alldoami commented Aug 1, 2021

@ChrisIsidora it's being imported indirectly... I see this line in the go.mod and go.sum

github.com/pkg/browser v0.0.0-20210706143420-7d21f8c997e2

but not the exact package.

@ChrisIsidora
Copy link
Contributor Author

@alldoami I opened another PR yesterday #626. Can you take a look?

jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ROW ACCESS POLICY
2 participants