fix: Handle optional account fields in the state upgrader correctly #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 1a44357ffb09b9c87744b4532be03c03e40fa46e |
sfc-gh-asawicki
approved these changes
Jan 9, 2025
|
Integration tests failure for f1447b1ca3cd4b228f984a2335ad4412c2fe2980 |
|
Integration tests cancelled for c7e463d17d664cf2efa7a8f1910ba5e1ccd7a432 |
sfc-gh-asawicki
approved these changes
Jan 9, 2025
|
Integration tests failure for 937c80af64dda25590f6b72aacd259e9d8732df0 |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jan 20, 2025
…3330) <!-- Feel free to delete comments as you fill this in --> - Fix handling optional account fields in the state upgrader. This error happened after importing accounts where the optional fields were not set—they are not populated in Import/Read. This resulted in empty values and panics. - The change has been verified manually. The acceptance test can be added in a follow-up (linked ticket) because of the potential limitations of the plugin SDK. - Fix failing tests. - Fix a few issues in docs. ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [ ] acceptance tests <!-- add more below if you think they are relevant --> * [ ] … ## References <!-- issues documentation links, etc --> #3328 #3332
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jan 20, 2025
…3330) <!-- Feel free to delete comments as you fill this in --> - Fix handling optional account fields in the state upgrader. This error happened after importing accounts where the optional fields were not set—they are not populated in Import/Read. This resulted in empty values and panics. - The change has been verified manually. The acceptance test can be added in a follow-up (linked ticket) because of the potential limitations of the plugin SDK. - Fix failing tests. - Fix a few issues in docs. ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [ ] acceptance tests <!-- add more below if you think they are relevant --> * [ ] … ## References <!-- issues documentation links, etc --> #3328 #3332
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jan 21, 2025
🤖 I have created a release *beep* *boop* --- ## [1.0.2](v1.0.1...v1.0.2) (2025-01-20) ### 🔧 **Misc** * Generate ID and ObjectType Show Object Methods ([#3292](#3292)) ([f7ff70a](f7ff70a)) * Generate multiline by default ([#3315](#3315)) ([520bb4c](520bb4c)) * Overview of the grant ownership resource ([#3342](#3342)) ([9f891d6](9f891d6)) * Update docs and migration guide ([#3313](#3313)) ([59e333a](59e333a)) ### 🐛 **Bug fixes:** * Fixes in account parameters ([#3310](#3310)) ([96a1f17](96a1f17)) * Handle optional account fields in the state upgrader correctly ([#3330](#3330)) ([4eae4c8](4eae4c8)), closes [#3332](#3332) * Small fixes ([#3337](#3337)) ([8807839](8807839)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
References
#3328 #3332