-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: datasource database role #2731
feat: datasource database role #2731
Conversation
Hey @mlorek. Thanks for the pull request. We will review it this week. |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
||
resource snowflake_database_role "test_role" { | ||
name = "%v" | ||
comment = "test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix formatting of Terraform config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a PR. We had a few suggestions, but after that we'll be good to merge 🙂.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, Thanks again for the contribution 🙂
/ok-to-test sha=c223343d0b0102faa7ab8d16b2c8a9d362cab26e |
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema" | ||
) | ||
|
||
var databaseRoleSchema = map[string]*schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs have to be generated for this one, so just run make pre-push
and the documentation should be generated. If any error pops up, refer to the contribution guidelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref to the last comment
Integration tests failure for c223343d0b0102faa7ab8d16b2c8a9d362cab26e |
/ok-to-test sha=e9108ff781c12a8d378d54ec8bdb8cf63ef7588d |
Integration tests failure for e9108ff781c12a8d378d54ec8bdb8cf63ef7588d |
/ok-to-test sha=7623db621e910b429a6be0f4e186fe2aafbd8bfb |
Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb |
3 similar comments
Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb |
Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb |
Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb |
Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb |
1 similar comment
Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb |
Hey 👋 |
🤖 I have created a release *beep* *boop* --- ## [0.91.0](v0.90.0...v0.91.0) (2024-05-16) ### 🎉 **What's new:** * add snowflake_grant_application_role resource ([#2690](#2690)) ([838d241](838d241)) * datasource database role ([#2731](#2731)) ([319ddc3](319ddc3)) ### 🔧 **Misc** * Add few documentation adjustments ([#2789](#2789)) ([6db8bf3](6db8bf3)) * Bump dependencies ([#2802](#2802)) ([54ea6bc](54ea6bc)) * Replace parsing function for saving granted object names ([#2813](#2813)) ([175cfc7](175cfc7)) ### 🐛 **Bug fixes:** * Fix sweepers ([#2800](#2800)) ([a01115e](a01115e)) * Invoke SetId immediately after alert creation ([#2786](#2786)) ([181b4d0](181b4d0)) * Update the tests after snowflake bugfix ([#2806](#2806)) ([6843c1a](6843c1a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Adding datasource - single database role
Test Plan
References