fix: golangci.yml to keep quality of codes #1296
Conversation
|
@sfc-gh-swinkler Could you please review this change? |
| _, err = snowflake.ListTagAssociations(builder, db) | ||
| if err != nil { | ||
| return errors.Wrap(err, "error validating tag association") | ||
| skipValidate := d.Get("skip_validation").(bool) |
There was a problem hiding this comment.
im wondering where this came from. could you please rebase to main?
There was a problem hiding this comment.
Sure! I think this came from other PR and I failed to operate merging other one. I'll check this carefully then fix around this.
There was a problem hiding this comment.
@sfc-gh-swinkler Again, thank you for your review. I checked changes around these lines and found just my deleting blank two lines. Does this problem come from somewhere else...?
|
could you please rebase to main? theres some changes to the tag_association resource i am thinking probably came from an old PR |
|
@sfc-gh-swinkler Could you please rerun workflow? |
|
@mnagaa thank you for your contribution! |
Summary
golangci lint does not work because of including unnecessary indent in the
.golangci.yml.Fixing the broken
.golangci.ymland invalid expressions in the existing go files are done in this PR.Notice that linters commented out in the file yaml file need fix many files, but they should work in the future.