feat: integer return type for procedure #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-swinkler
changed the title
|
Integration tests failure for 412ac5ff4141d16aea3fc2269b16b6a87534c1ad |
|
Integration tests failure for 339dc4e53c348a0a6f85ee32b9c8f4c9ed953a6f |
|
Integration tests failure for 5e565fe2b69ad5390f08cadd88f6538ad0145289 |
|
Integration tests failure for b59b20e675e6b935446ca2e0d93c682d341cfd5d |
|
Integration tests failure for c3cbc82be91ef5bf0c9c2c5b8b4b1fc33e178764 |
|
Integration tests failure for e8d7a29eb71dc4e49ff9d5579c796011a7e553d0 |
|
Integration tests failure for 07ccbf6d774d78ff0993cc90c58119caba68bd56 |
|
Integration tests success for d9a7219ddfddf5ed997077f1e97c1648df8da600 |
sfc-gh-jlove
approved these changes
Oct 11, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a problem with stored procedures that prevented INTEGER from being set as a return type. Internally it was being converted to NUMBER(38,0). so now using a diffsupress function to ignore the difference for equivalents when being read.
Test Plan
References