fix: Fix snowflake_share resource not unsetting accounts #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for be7d80a34796bea8e7fb688f40a205075cd0f7b1 |
|
Integration tests failure for a7d1c1894bdf1542df8f77f9733287e69644d489 |
|
Integration tests failure for fc62e8d11f1cb8eecfde26720060c76441a387ed |
|
Integration tests failure for 55051a8a80bc9f8c94a1f14930d95c8fb9c38149 |
|
Integration tests success for d0cf9cba0cc4c7bc0d7400f14e66bb36d98a113d |
|
Integration tests success for 3574159b758f3af9f4afe992d9e4c7c9f7e28026 |
sfc-gh-swinkler
approved these changes
Aug 24, 2022
pkg/resources/share.go
Outdated
| @@ -90,7 +90,7 @@ func setAccounts(d *schema.ResourceData, meta interface{}) error { | |||
| name := d.Get("name").(string) | |||
| accs := expandStringList(d.Get("accounts").([]interface{})) | |||
|
|
|||
| if len(accs) > 0 { | |||
| if len(accs) >= 0 { | |||
There was a problem hiding this comment.
i'm pretty sure this does nothing since the default value is an empty list
There was a problem hiding this comment.
can you please remove this unnecessary check?
| @@ -15,6 +16,8 @@ const ( | |||
|
|
|||
| func TestAcc_Share(t *testing.T) { | |||
| name := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)) | |||
| account2 := os.Getenv("account2") | |||
There was a problem hiding this comment.
if you pass in any account will it work? for example a random string?
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going from a list of accounts to an empty list on the share resource would not remove the accounts from the share. This was a bug. This fix fixes that bug.
Test Plan