-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove validate_utf8 parameter from file_format #1166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jalin
changed the title
Remove validate_utf8 parameter from file_format
fix: Remove validate_utf8 parameter from file_format
Aug 3, 2022
/ok-to-test sha=a095e4b |
Integration tests failure for a095e4b |
/ok-to-test sha=8685efd |
Integration tests failure for 8685efd |
not sure those errors are to do with the commit? 😬 |
/ok-to-test sha=8685ef5 |
Apologies, I entered the wrong commit ID. Rerunning the tests now |
Integration tests success for 8685ef5 |
sfc-gh-jalin
approved these changes
Aug 4, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove validate_utf8 parameter from file_format due to obsoletion from Snowflake
Test Plan
References