Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not_null failure where error tolerance #41

Closed
StuartMiddleton opened this issue Dec 6, 2022 · 1 comment · Fixed by #55
Closed

not_null failure where error tolerance #41

StuartMiddleton opened this issue Dec 6, 2022 · 1 comment · Fixed by #55
Assignees

Comments

@StuartMiddleton
Copy link

We have a test as follows:

        tests:
          - not_null:
              config:
                severity: error
                error_if: ">1000"
                warn_if: ">1000"

The purpose of this test is to ensure a certain data completion tolerance and flag where this tolerance is not being met for the business to take action.

Behaviour for newer versions of dbt_constraints attempts to apply a not_null constraint in this situation and fails because it's not a true not_null in the database sense. There needs to be some means to ignore the implementation of this constraint - automatic or by configuration.

@sfc-gh-dflippo sfc-gh-dflippo self-assigned this Jul 28, 2023
@sfc-gh-dflippo
Copy link
Collaborator

Sorry it took so long to get around to this but I am going to filter out tests with an error_if configuration.

@sfc-gh-dflippo sfc-gh-dflippo linked a pull request Jul 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants