Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add constraints to seeds #37

Closed
sfc-gh-cwiese opened this issue Nov 28, 2022 · 2 comments · Fixed by #39
Closed

Feature request: add constraints to seeds #37

sfc-gh-cwiese opened this issue Nov 28, 2022 · 2 comments · Fixed by #39
Assignees
Labels
enhancement New feature or request

Comments

@sfc-gh-cwiese
Copy link

As a developer, I would like dbt_constraints to add constraints for my tests on seeds, so that I can benefit from join elimination in queries on my seed tables.

@kenho811
Copy link

kenho811 commented Dec 4, 2022

Hi,

I have a similar request.

  dbt_constraints_seeds_enabled: true

The above configuration does not seem to work.

@sfc-gh-dflippo sfc-gh-dflippo added the enhancement New feature or request label Dec 5, 2022
@sfc-gh-dflippo sfc-gh-dflippo self-assigned this Dec 5, 2022
@sfc-gh-dflippo
Copy link
Collaborator

@kenho811 , I am checking in the code now but it won't actually require a new parameter to enable. I have that parameter for sources because they are more likely to be created by an external process and we are more likely to not have privileges to modify sources. Because a seed is created from your own project, I can assume you have privileges to add constraints to them, just like I do for models and snapshots.

@sfc-gh-dflippo sfc-gh-dflippo linked a pull request Dec 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants