Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Zend\Stdlib\JsonSerializable vs Laminas\Stdlib\JsonSerializable #153

Open
aurelien-andre-weldom opened this issue Apr 12, 2023 · 0 comments

Comments

@aurelien-andre-weldom
Copy link

Smile\StoreLocator\Model\Data\RetailerTimeSlot use Zend\Stdlib\JsonSerializable without composer dependency

Preconditions

Magento Version : 2.4.4 ee (php 8.1)

Module Store Locator Version : 2.0.8

Environment : All

Steps to reproduce

  1. composer install without Zend\Stdlib\JsonSerializable
  2. bin/magento setup:di:compile

Expected result

  1. composer.json must be required "laminas/laminas-stdlib": "^3.17" OR delete methode / interface not used.

Actual result

  1. MiBPHP Fatal error: During inheritance of JsonSerializable: Uncaught Exception: Deprecated Functionality: Return type of Smile\StoreLocator\Model\Data\RetailerTimeSlot::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /src/vendor/smile/module-store-locator/Model/Data/RetailerTimeSlot.php on line 72 in /src/vendor/magento/framework/App/ErrorHandler.php:61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant